Issue 10010004: Implement @runtime-error in co19 tests for static analysis (no runtime)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10010004: Implement @runtime-error in co19 tests for static analysis (no runtime) (Closed)

Created:
8 years, 8 months ago by zundel

Modified:
8 years, 8 months ago

Reviewers:
Emily Fortuna, scheglov, Mads Ager (chromium)

CC:
reviews_dartlang.org, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement @runtime-error in co19 tests for static analysis (no runtime) http://code.google.com/p/dart/issues/detail?id=2406 Committed: https://code.google.com/p/dart/source/detail?r=6243

Patch Set 1 : Formatting fix. #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -10 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java	View	1 chunk	+7 lines, -5 lines	1 comment	Download
M	tests/co19/co19-compiler.status	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

Fixes the @runtime-error annotation in test.dart for dartc. Also fixes one bug in dartc uncovered ...

8 years, 8 months ago (2012-04-05 11:54:32 UTC) #1

zundel

https://chromiumcodereview.appspot.com/10010004/diff/1004/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java File compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java (left): https://chromiumcodereview.appspot.com/10010004/diff/1004/compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java#oldcode19 compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java:19: NO_ENTRY_POINT("No entrypoint specified for app"); no references in the ...

8 years, 8 months ago (2012-04-05 12:07:27 UTC) #2

lgtm!

Expand Messages | Collapse Messages