Fix static field inspection in debugger

Fix static field inspection in debugger

- Handle static fields that have no getter (issue 2462).
- Get correct value of initialized fields (issue 2221).
- Add test case.
Committed: https://code.google.com/p/dart/source/detail?r=6251

[regis, 2012-04-05 22:33:05]

LGTM

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:754: if (getter_func.IsNull()) {
This contradicts the assert above. Left over debugging code?

[hausner, 2012-04-05 22:45:30]

Thanks for the fast turnaround!

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:754: if (getter_func.IsNull()) {
On 2012/04/05 22:33:05, regis wrote:
> This contradicts the assert above. Left over debugging code?

I did this on purpose. Maybe it's not good style. This function should never be
called with the name of a non-existing field/getter. In a debug build I'd like
to know if someone tries to get the value of a non-existing field. In release
mode, I just silently ignore this and return null as the value.

[regis, 2012-04-05 23:03:07]

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/10009023/diff/4001/runtime/vm/debugger.cc#newc...
runtime/vm/debugger.cc:754: if (getter_func.IsNull()) {
On 2012/04/05 22:45:30, hausner wrote:
> On 2012/04/05 22:33:05, regis wrote:
> > This contradicts the assert above. Left over debugging code?
> 
> I did this on purpose. Maybe it's not good style. This function should never
be
> called with the name of a non-existing field/getter. In a debug build I'd like
> to know if someone tries to get the value of a non-existing field. In release
> mode, I just silently ignore this and return null as the value.

Don't you want to know that something is fishy in release mode too? Instead of
returning null, I would have called an UNREACHABLE() for a null function. But
maybe you need a more defensive coding style in the debugger? Up to you.