Issue 10008038: Fix typo and build v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10008038: Fix typo and build v8. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix typo and build v8. Committed: https://code.google.com/p/dart/source/detail?r=6259

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -45 lines)			Patch
	M	tools/testing/perf_testing/run_perf_tests.py	View	1	11 chunks	+73 lines, -45 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

I wasn't able to find where you were generating the files with names like "getElementsByTagName(p)dromaeo.png" ...

8 years, 8 months ago (2012-04-06 02:00:52 UTC) #2

vsm

8 years, 8 months ago (2012-04-06 03:53:42 UTC) #5

lgtm

https://chromiumcodereview.appspot.com/10008038/diff/1002/tools/testing/perf_...
File tools/testing/perf_testing/run_perf_tests.py (right):

https://chromiumcodereview.appspot.com/10008038/diff/1002/tools/testing/perf_...
tools/testing/perf_testing/run_perf_tests.py:674: 
Extraneous whitespace?

Expand Messages | Collapse Messages