Issue 10008030: Inline the StackResource constructor/destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10008030: Inline the StackResource constructor/destructor. (Closed)

Created:
8 years, 8 months ago by turnidge

Modified:
8 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Inline the StackResource constructor/destructor. This yields a 29% improvement on the Benchmark_UseDartApi microbenchmark. To do this, I had to split a few fields from Isolate into a BaseIsolate class. Sort of yucky. Committed: https://code.google.com/p/dart/source/detail?r=6288

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+160 lines, -112 lines)			Patch
M	vm/allocation.h	View	1 2 3 4	2 chunks	+24 lines, -4 lines	0 comments	Download
M	vm/allocation.cc	View	1 2 3 4	1 chunk	+0 lines, -21 lines	0 comments	Download
A	vm/base_isolate.h	View	1 2	1 chunk	+117 lines, -0 lines	0 comments	Download
M	vm/handles.h	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	vm/handles.cc	View	1 2 3 4	2 chunks	+2 lines, -2 lines	0 comments	Download
M	vm/isolate.h	View	1 2 3 4	5 chunks	+2 lines, -71 lines	0 comments	Download
M	vm/isolate.cc	View	1 2 3 4	4 chunks	+9 lines, -9 lines	0 comments	Download
M	vm/vm_sources.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	vm/zone.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/zone.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

Not completely sure I like this, but it does make things faster. Let me know ...

8 years, 8 months ago (2012-04-05 23:39:16 UTC) #1

siva

lgtm https://chromiumcodereview.appspot.com/10008030/diff/1003/vm/base_isolate.h File vm/base_isolate.h (right): https://chromiumcodereview.appspot.com/10008030/diff/1003/vm/base_isolate.h#newcode36 vm/base_isolate.h:36: Zone* current_zone_; DISALLOW_COPY_AND_ASSIGN(BaseIsolate);

8 years, 8 months ago (2012-04-06 17:30:14 UTC) #2

turnidge

8 years, 8 months ago (2012-04-06 17:50:40 UTC) #3

https://chromiumcodereview.appspot.com/10008030/diff/1003/vm/base_isolate.h
File vm/base_isolate.h (right):

https://chromiumcodereview.appspot.com/10008030/diff/1003/vm/base_isolate.h#n...
vm/base_isolate.h:36: Zone* current_zone_;
On 2012/04/06 17:30:14, asiva wrote:
> DISALLOW_COPY_AND_ASSIGN(BaseIsolate);

Done.

Expand Messages | Collapse Messages