Add a test to check correct references to a global variable that initially throws

Add a test to check correct references to a global variable that initially throws
a type error.
Committed: https://code.google.com/p/dart/source/detail?r=6294

[regis, 2012-04-06 19:03:17]

LGMT

Feel free to ignore my suggestion to rename the test.

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/languag...
File tests/language/language-leg.status (right):

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/languag...
tests/language/language-leg.status:12: TypeErrorTest: Fail # Checked mode not
supported.
TypeErrorTest is a bit vague.
StaticInitializerTypeErrorTest, maybe?

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
File tests/language/src/TypeErrorTest.dart (right):

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:6: // VMOptions=--enable_type_checks
--enable_asserts
--enable_asserts is not necessary.
We should fix them all at some time.

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:16: x = 5;  // Make sure we do not thorw
exception a second time.
thorw

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:28: // In checked mode throw only one
exception,
, -> .

[srdjan, 2012-04-06 20:07:33]

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/languag...
File tests/language/language-leg.status (right):

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/languag...
tests/language/language-leg.status:12: TypeErrorTest: Fail # Checked mode not
supported.
On 2012/04/06 19:03:17, regis wrote:
> TypeErrorTest is a bit vague.
> StaticInitializerTypeErrorTest, maybe?

Done.

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
File tests/language/src/TypeErrorTest.dart (right):

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:6: // VMOptions=--enable_type_checks
--enable_asserts
On 2012/04/06 19:03:17, regis wrote:
> --enable_asserts is not necessary.
> We should fix them all at some time.

Done.

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:16: x = 5;  // Make sure we do not thorw
exception a second time.
On 2012/04/06 19:03:17, regis wrote:
> thorw

Done.

https://chromiumcodereview.appspot.com/10006040/diff/1/tests/language/src/Typ...
tests/language/src/TypeErrorTest.dart:28: // In checked mode throw only one
exception,
On 2012/04/06 19:03:17, regis wrote:
> , -> .

Done.

[hausner, 2012-04-06 20:15:03]

lgtm

https://chromiumcodereview.appspot.com/10006040/diff/5001/tests/language/src/...
File tests/language/src/StaticInitializerTypeErrorTest.dart (right):

https://chromiumcodereview.appspot.com/10006040/diff/5001/tests/language/src/...
tests/language/src/StaticInitializerTypeErrorTest.dart:4: // Dart test program
for testing isolate communication with
Comment is outdated/wrong.

[srdjan, 2012-04-06 20:20:37]

https://chromiumcodereview.appspot.com/10006040/diff/5001/tests/language/src/...
File tests/language/src/StaticInitializerTypeErrorTest.dart (right):

https://chromiumcodereview.appspot.com/10006040/diff/5001/tests/language/src/...
tests/language/src/StaticInitializerTypeErrorTest.dart:4: // Dart test program
for testing isolate communication with
On 2012/04/06 20:15:04, hausner wrote:
> Comment is outdated/wrong. 

Done.

[srdjan, 2012-04-06 20:25:11]

Also added the change to parser.cc that initializes a field to NULL (from
sentinel) if an exception has been thrown. (TBR)

[regis, 2012-04-06 20:27:32]

LGTM

Thanks for submitting this new test. I'll work on the bug now.

[hausner, 2012-04-06 20:41:14]

lgtm