Support DOMStringMap in generators.

Support DOMStringMap in generators.

R=podivilov@chromium.org,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=6267

[podivilov, 2012-04-06 12:05:40]

lgtm

[sra1, 2012-04-06 18:23:39]

https://chromiumcodereview.appspot.com/10005017/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10005017/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:20: 'DOMStringMap': 'Map<String, String>',
We can't do this.

There is a DOMStringMap type.
In the JavaScript world, element.dataset returns an object that satisfies  (x
instanceof DOMStringMap).
DOMStringMap should *implement* Map<String, String>.

An interface method / getter may returning DOMStringMap may widen to
Map<String,String> but the implementation class (in the frog code) absolutely
must have the correct implementation type.

DOMStringMap is magical - 
element.dataset['foo'] = bar
modifies the element to add a data-foo attribute.

DOMStringList also needs to be handled correctly.
When we access IDBDatabase.objectStoreNames we get a DOMStringList which needs
to implement List<String>
There are two differences:
1. DOMStringList is immutable so no magical behaviour
2. DOMStringList is also an input (e.g. to IDBDatabase.transaction), so this
needs to work:

    mydatabase.transaction(mydatabase.objectStoreNames, ...)

[Anton Muhin, 2012-04-09 09:50:51]

https://chromiumcodereview.appspot.com/10005017/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10005017/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:20: 'DOMStringMap': 'Map<String, String>',
On 2012/04/06 18:23:39, sra1 wrote:
> We can't do this.

No, we can :)

> There is a DOMStringMap type.

No, as of now there are none.  As there was no dataset attribute on Element
interface---this line is necessary to make us generate dataset attribute if we
remove DOMStringMap interface as we do now.

> In the JavaScript world, element.dataset returns an object that satisfies  (x
> instanceof DOMStringMap).
> DOMStringMap should *implement* Map<String, String>.
> 
> An interface method / getter may returning DOMStringMap may widen to
> Map<String,String> but the implementation class (in the frog code) absolutely
> must have the correct implementation type.

No doubt about that.

> DOMStringMap is magical - 
> element.dataset['foo'] = bar
> modifies the element to add a data-foo attribute.

That's NodeList's level of magic.

> DOMStringList also needs to be handled correctly.

No doubt about that as well.

> When we access IDBDatabase.objectStoreNames we get a DOMStringList which needs
> to implement List<String>
> There are two differences:
> 1. DOMStringList is immutable so no magical behaviour
> 2. DOMStringList is also an input (e.g. to IDBDatabase.transaction), so this
> needs to work:
> 
>     mydatabase.transaction(mydatabase.objectStoreNames, ...)
> 

Absolutely, I even already have a todo for that in Dartium code.