Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: pylib/gyp/win_tool.py

Issue 9969078: ninja windows: suppress 'Creating library...' output (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/generator/ninja.py ('K') | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/win_tool.py
diff --git a/pylib/gyp/win_tool.py b/pylib/gyp/win_tool.py
index ba2e86bcb57bbd738a14f395ae935b27f53d5511..bd4cbfad4d81f12b93854c27e320f75792b1ce6e 100644
--- a/pylib/gyp/win_tool.py
+++ b/pylib/gyp/win_tool.py
@@ -11,6 +11,7 @@ These functions are executed via gyp-win-tool when using the ninja generator.
import os
import shutil
+import subprocess
import sys
@@ -49,6 +50,19 @@ class WinTool(object):
else:
shutil.copy2(source, dest)
+ def ExecLinkSuppressImportLibName(self, *args):
+ """Filter diagnostic output from link that looks like:
+ ' Creating library ui.dll.lib and object ui.dll.exp'
+ This happens when there are exports from the dll or exe.
+ """
+ popen = subprocess.Popen(args,
+ stdout=subprocess.PIPE,
+ stderr=subprocess.STDOUT)
+ out, _ = popen.communicate()
Nico 2012/04/03 23:00:39 nit: for line in out: if not line.startswith('
+ lines = filter(lambda x: not x.startswith(' Creating library '),
+ out.splitlines())
+ sys.stdout.write('\n'.join(lines))
+ return popen.returncode
if __name__ == '__main__':
sys.exit(main(sys.argv[1:]))
« pylib/gyp/generator/ninja.py ('K') | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698