content/renderer/renderer_webkitplatformsupport_impl.cc - Issue 9950141: Mac: OOP font loading should run on FILE thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_webkitplatformsupport_impl.cc

Issue 9950141: Mac: OOP font loading should run on FILE thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/renderer_webkitplatformsupport_impl.cc

diff --git a/content/renderer/renderer_webkitplatformsupport_impl.cc b/content/renderer/renderer_webkitplatformsupport_impl.cc

index 7afb22d305d610e90e97cde087430dbacb865d3c..44e3e5c48b81df7134d7db7fd509142f54b888b5 100644

--- a/content/renderer/renderer_webkitplatformsupport_impl.cc

+++ b/content/renderer/renderer_webkitplatformsupport_impl.cc

@@ -501,7 +501,7 @@ bool RendererWebKitPlatformSupportImpl::SandboxSupport::loadFont(

if (font_data_size == 0 || font_data == base::SharedMemory::NULLHandle() ||

*font_id == 0) {

- NOTREACHED() << "Bad response from ViewHostMsg_LoadFont() for " <<

+ LOG(ERROR) << "Bad response from ViewHostMsg_LoadFont() for " <<

src_font_descriptor.font_name;

*out = NULL;

*font_id = 0;