Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9699065: "index" property should be optional with "chrome.tabs.move" (Closed)

Created:
8 years, 9 months ago by mitchellwrosen
Modified:
8 years, 7 months ago
Reviewers:
Jay Civelli, Matt Perry
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

"index" property should be optional with "chrome.tabs.move" Made the "index" property of "chrome.tabs.move" optional BUG=33048 TEST=ExtensionApiTest.TabMove Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136741

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Patch Set 3 : Index no longer optional, but -1 means append tab to the end #

Total comments: 4

Patch Set 4 : Small changes per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -54 lines) Patch
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/tabs.json View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/declarativeWebRequest.html View 1 2 3 3 chunks +4 lines, -13 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/tabs.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/tabs/basics/move.js View 1 2 3 8 chunks +62 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mitchellwrosen
8 years, 9 months ago (2012-03-15 04:54:12 UTC) #1
clintstaley
http://codereview.chromium.org/9699065/diff/1/chrome/browser/extensions/extension_tabs_module.cc File chrome/browser/extensions/extension_tabs_module.cc (right): http://codereview.chromium.org/9699065/diff/1/chrome/browser/extensions/extension_tabs_module.cc#newcode1416 chrome/browser/extensions/extension_tabs_module.cc:1416: new_index = std::numeric_limits<int>::max(); // Will get clamped . after ...
8 years, 9 months ago (2012-03-20 17:19:29 UTC) #2
mitchellwrosen
http://codereview.chromium.org/9699065/diff/1/chrome/browser/extensions/extension_tabs_module.cc File chrome/browser/extensions/extension_tabs_module.cc (right): http://codereview.chromium.org/9699065/diff/1/chrome/browser/extensions/extension_tabs_module.cc#newcode1416 chrome/browser/extensions/extension_tabs_module.cc:1416: new_index = std::numeric_limits<int>::max(); // Will get clamped On 2012/03/20 ...
8 years, 9 months ago (2012-03-27 01:19:49 UTC) #3
chebert
lgtm
8 years, 8 months ago (2012-04-07 16:53:56 UTC) #4
mitchellwrosen
8 years, 8 months ago (2012-04-07 21:05:11 UTC) #5
Matt Perry
Aaron updated the bug, but I'll add it here as well: how about -1 instead?
8 years, 8 months ago (2012-04-09 20:35:28 UTC) #6
mitchellwrosen
On 2012/04/09 20:35:28, Matt Perry wrote: > Aaron updated the bug, but I'll add it ...
8 years, 8 months ago (2012-04-09 20:38:11 UTC) #7
Matt Perry
On 2012/04/09 20:38:11, mitchellwrosen wrote: > On 2012/04/09 20:35:28, Matt Perry wrote: > > Aaron ...
8 years, 8 months ago (2012-04-09 20:42:07 UTC) #8
mitchellwrosen
8 years, 8 months ago (2012-04-13 21:59:12 UTC) #9
mitchellwrosen
8 years, 7 months ago (2012-05-11 02:38:39 UTC) #10
Matt Perry
https://chromiumcodereview.appspot.com/9699065/diff/12001/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://chromiumcodereview.appspot.com/9699065/diff/12001/chrome/common/extensions/api/tabs.json#newcode462 chrome/common/extensions/api/tabs.json:462: "optional": true, I don't think this should be optional. ...
8 years, 7 months ago (2012-05-11 19:30:39 UTC) #11
mitchellwrosen
https://chromiumcodereview.appspot.com/9699065/diff/12001/chrome/common/extensions/api/tabs.json File chrome/common/extensions/api/tabs.json (right): https://chromiumcodereview.appspot.com/9699065/diff/12001/chrome/common/extensions/api/tabs.json#newcode462 chrome/common/extensions/api/tabs.json:462: "optional": true, On 2012/05/11 19:30:39, Matt Perry wrote: > ...
8 years, 7 months ago (2012-05-12 00:26:06 UTC) #12
Matt Perry
lgtm
8 years, 7 months ago (2012-05-12 00:28:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/9699065/18002
8 years, 7 months ago (2012-05-12 00:32:24 UTC) #14
commit-bot: I haz the power
8 years, 7 months ago (2012-05-12 01:57:26 UTC) #15 
Change committed as 136741

Powered by Google App Engine
This is Rietveld 408576698