Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 9617012: Allow std{in,out,err} to be a socket (Closed)

Created:
8 years, 9 months ago by Dan Rice
Modified:
8 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow std{in,out,err} to be a socket

Patch Set 1 #

Patch Set 2 : Respond to review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M runtime/bin/file.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file_linux.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/stdio.dart View 1 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dan Rice
8 years, 9 months ago (2012-03-06 17:49:50 UTC) #1
Søren Gjesse
On 2012/03/06 17:49:50, Dan Rice wrote: This will work, however please add kSocket to runtime/bin/file.h ...
8 years, 9 months ago (2012-03-06 20:01:52 UTC) #2
Dan Rice
You can test it using the 'socat' command (http://www.dest-unreach.org/socat/), which has a mode in which ...
8 years, 9 months ago (2012-03-06 20:55:30 UTC) #3
Søren Gjesse
lgtm Thanks for fixing this.
8 years, 9 months ago (2012-03-06 21:21:26 UTC) #4
Dan Rice
8 years, 9 months ago (2012-03-06 21:39:23 UTC) #5
r5056

Powered by Google App Engine
This is Rietveld 408576698