Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: test/win/gyptest-cl_buffer_security_check.py

Issue 9460049: Next level of changes to get more of Chrome building (Closed) Base URL: https://gyp.googlecode.com/svn/trunk
Patch Set: wip Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/win/gyptest-cl_additional_options.py ('k') | test/win/gyptest-cl_character_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/gyptest-cl_buffer_security_check.py
diff --git a/test/win/gyptest-cl_buffer_security_check.py b/test/win/gyptest-cl_buffer_security_check.py
new file mode 100644
index 0000000000000000000000000000000000000000..c1aeac592ac3bc24ea9907ff14b04189ce32fc98
--- /dev/null
+++ b/test/win/gyptest-cl_buffer_security_check.py
@@ -0,0 +1,32 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Make sure buffer security check setting is extracted properly.
+"""
+
+import TestGyp
+
+import subprocess
+import sys
+
+if sys.platform == 'win32':
+ test = TestGyp.TestGyp(formats=['ninja'])
+
+ CHDIR = 'compiler_flags'
+ test.run_gyp('buffer-security-check.gyp', chdir=CHDIR)
+
+ ninja_file = test.built_file_path('obj/test_bsc_off.ninja', chdir=CHDIR)
+ test.must_contain(ninja_file, 'cflags = /GS-')
+
+ ninja_file = test.built_file_path('obj/test_bsc_on.ninja', chdir=CHDIR)
+ test.must_contain(ninja_file, 'cflags = /GS')
+ test.must_not_contain(ninja_file, '/GS-')
+
+ # TODO(scottmg): It says "on by default", not sure if that's on-by-default
+ # in IDE or compiler.
+
+ test.pass_test()
« no previous file with comments | « test/win/gyptest-cl_additional_options.py ('k') | test/win/gyptest-cl_character_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698