Retrieve generator variables and use those for prefix/suffix, rather than repeating

pylib/gyp/generator/ninja_test.py

Index: pylib/gyp/generator/ninja_test.py
===================================================================
--- pylib/gyp/generator/ninja_test.py	(revision 0)
+++ pylib/gyp/generator/ninja_test.py	(revision 0)
@@ -0,0 +1,42 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2012 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+""" Unit tests for the ninja.py file. """
+
+import gyp.generator.ninja as ninja
+import unittest
+import StringIO
+import TestCommon
+
+

[Nico, 2012/02/16 23:40:18]

FWIW, I think system tests are better to explain _why_ this needs to match. I'd
have a reduced version of the nacl gyp file instead.

+class TestPrefixesAndSuffixes(unittest.TestCase):
+  def test_BinaryNamesWindows(self):
+    writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'win')
+    spec = { 'target_name': 'wee' }
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'executable').
+        endswith('.exe'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'shared_library').
+        endswith('.dll'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'static_library').
+        endswith('.lib'))
+
+  def test_BinaryNamesLinux(self):
+    writer = ninja.NinjaWriter('wee', '.', '.', 'ninja.build', 'linux')
+    spec = {
+      'target_name': 'wee'
+    }
+    self.assertTrue('.' not in writer.ComputeOutputFileName(spec, 'executable'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'shared_library').
+        startswith('lib'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'static_library').
+        startswith('lib'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'shared_library').
+        endswith('.so'))
+    self.assertTrue(writer.ComputeOutputFileName(spec, 'static_library').
+        endswith('.a'))
+
+if __name__ == '__main__':
+  unittest.main()
Property changes on: pylib\gyp\generator\ninja_test.py
___________________________________________________________________
Added: svn:eol-style
   + LF