Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 9420031: Retrieve generator variables and use those for prefix/suffix, rather than repeating (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Retrieve generator variables, rather than repeating. A bit ugly to retrieve again via CalculateVariables, but seems better than having a second copy where I can break 'em. :/ It looks like other uses of generator_default_variables look like they might be semi-incorrect too, but maybe doesn't matter much. Committed: https://code.google.com/p/gyp/source/detail?r=1211

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -34 lines) Patch
M pylib/gyp/generator/ninja.py View 1 3 chunks +22 lines, -33 lines 0 comments Download
A pylib/gyp/generator/ninja_test.py View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
M test/small/gyptest-small.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
8 years, 10 months ago (2012-02-16 23:34:33 UTC) #1
Nico
LGTM (The prefixes / suffixes are duplicated in gyp/xcode_emulation.py too iirc. But the mac side ...
8 years, 10 months ago (2012-02-16 23:40:18 UTC) #2
scottmg
8 years, 10 months ago (2012-02-16 23:49:01 UTC) #3
On 2012/02/16 23:40:18, Nico wrote:
> FWIW, I think system tests are better to explain _why_ this needs to match.
I'd
> have a reduced version of the nacl gyp file instead.

You're right, that would be better for the nacl_bootstrap_raw wacky link thing.
I was thinking that even if that case worked either way, it's just better to
avoid having the non-normal prefixes or suffixes.

Powered by Google App Engine
This is Rietveld 408576698