Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 9401016: Fix .d for ninja on Windows (Closed)

Created:
8 years, 10 months ago by scottmg
Modified:
8 years, 10 months ago
Reviewers:
Nico, Evan Martin
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix .ds for ninja on Windows Currently relies on 'deplist' branch of ninja. Also fix some prefixes/suffixes for Windows. Tests in test/hello now pass. Committed: https://code.google.com/p/gyp/source/detail?r=1202

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -21 lines) Patch
M pylib/gyp/generator/ninja.py View 3 chunks +40 lines, -20 lines 1 comment Download
M pylib/gyp/ninja_syntax.py View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
scottmg
8 years, 10 months ago (2012-02-15 19:48:14 UTC) #1
Evan Martin
LGTM https://chromiumcodereview.appspot.com/9401016/diff/1/pylib/gyp/ninja_syntax.py File pylib/gyp/ninja_syntax.py (right): https://chromiumcodereview.appspot.com/9401016/diff/1/pylib/gyp/ninja_syntax.py#newcode46 pylib/gyp/ninja_syntax.py:46: self.variable('deplist', deplist, indent=1) Hm, in theory this file ...
8 years, 10 months ago (2012-02-15 19:53:04 UTC) #2
scottmg
On 2012/02/15 19:53:04, Evan Martin wrote: > LGTM > > https://chromiumcodereview.appspot.com/9401016/diff/1/pylib/gyp/ninja_syntax.py > File pylib/gyp/ninja_syntax.py (right): ...
8 years, 10 months ago (2012-02-15 21:55:46 UTC) #3
Nico
8 years, 10 months ago (2012-02-16 19:32:26 UTC) #4
https://chromiumcodereview.appspot.com/9401016/diff/1/pylib/gyp/generator/nin...
File pylib/gyp/generator/ninja.py (right):

https://chromiumcodereview.appspot.com/9401016/diff/1/pylib/gyp/generator/nin...
pylib/gyp/generator/ninja.py:834: if self.flavor == 'win':
This should be !=, or you need to swap the branch bodies.

(This is breaking the linux build with nacl enabled)

Powered by Google App Engine
This is Rietveld 408576698