Implement STYLE_LOWERCASE style for Aura NativeTextfield.

ui/views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
+#include "base/i18n/case_conversion.h"
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "grit/app_locale_settings.h"
 #include "grit/ui_strings.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/range/range.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/compositor/layer.h"
 #include "ui/gfx/insets.h"
 #include "ui/gfx/render_text.h"
 #include "ui/views/background.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/focusable_border.h"
 #include "ui/views/controls/menu/menu_item_view.h"
 #include "ui/views/controls/menu/menu_model_adapter.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/controls/textfield/textfield_controller.h"
 #include "ui/views/controls/textfield/textfield_views_model.h"
 #include "ui/views/events/event.h"
 #include "ui/views/ime/input_method.h"
 #include "ui/views/metrics.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/widget.h"
+#include "unicode/uchar.h"
 
 #if defined(USE_AURA)
 #include "ui/base/cursor/cursor.h"
 #endif
 
 namespace {
 
 // Text color for read only.
 const SkColor kReadonlyTextColor = SK_ColorDKGRAY;
 
@@ skipping 20 matching lines @@
       skip_input_method_cancel_composition_(false),
       initiating_drag_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(cursor_timer_(this)),
       aggregated_clicks_(0),
       last_click_time_(),
       last_click_location_(),
       ALLOW_THIS_IN_INITIALIZER_LIST(touch_selection_controller_(
           TouchSelectionController::create(this))) {
   set_border(text_border_);
 
-  // Lowercase is not supported.
-  DCHECK_NE(parent->style(), Textfield::STYLE_LOWERCASE);
-
 #if defined(OS_CHROMEOS)
   GetRenderText()->SetFontList(gfx::FontList(l10n_util::GetStringUTF8(
       IDS_UI_FONT_FAMILY_CROS)));
 #else
   GetRenderText()->SetFontList(gfx::FontList(textfield_->font()));
 #endif
   // Set the default text style.
   gfx::StyleRange default_style;
   default_style.foreground = textfield_->text_color();
   GetRenderText()->set_default_style(default_style);
@@ skipping 98 matching lines @@
   DCHECK(CanDrop(event.data()));
   DCHECK(!initiating_drag_ ||
          !GetRenderText()->IsPointInSelection(event.location()));
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
 
   gfx::SelectionModel drop_destination_model =
       GetRenderText()->FindCursorPosition(event.location());
   string16 text;
   event.data().GetString(&text);
+  if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+    text = base::i18n::ToLower(text);
 
   // We'll delete the current selection for a drag and drop within this view.
   bool move = initiating_drag_ && !event.IsControlDown() &&
               event.source_operations() & ui::DragDropTypes::DRAG_MOVE;
   if (move) {
     gfx::SelectionModel selected;
     model_->GetSelectionModel(&selected);
     // Adjust the drop destination if it is on or after the current selection.
     size_t drop_destination = drop_destination_model.caret_pos();
     drop_destination -=
@@ skipping 103 matching lines @@
 }
 
 /////////////////////////////////////////////////////////////////
 // NativeTextfieldViews, NativeTextifieldWrapper overrides:
 
 string16 NativeTextfieldViews::GetText() const {
   return model_->GetText();
 }
 
 void NativeTextfieldViews::UpdateText() {
-  model_->SetText(textfield_->text());
+  string16 text = textfield_->text();
+  if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+    text = base::i18n::ToLower(text);
+  model_->SetText(text);
   OnCaretBoundsChanged();
   SchedulePaint();
   textfield_->GetWidget()->NotifyAccessibilityEvent(
       textfield_, ui::AccessibilityTypes::EVENT_TEXT_CHANGED, true);
 }
 
 void NativeTextfieldViews::AppendText(const string16& text) {
   if (text.empty())
     return;
-  model_->Append(text);
+  if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+    model_->Append(base::i18n::ToLower(text));
+  else
+    model_->Append(text);
   OnCaretBoundsChanged();
   SchedulePaint();
 }
 
 string16 NativeTextfieldViews::GetSelectedText() const {
   return model_->GetSelectedText();
 }
 
 void NativeTextfieldViews::SelectAll() {
   OnBeforeUserAction();
@@ skipping 316 matching lines @@
   OnAfterUserAction();
 }
 
 void NativeTextfieldViews::InsertText(const string16& text) {
   // TODO(suzhe): Filter invalid characters.
   if (GetTextInputType() == ui::TEXT_INPUT_TYPE_NONE || text.empty())
     return;
 
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
+
+  string16 new_text = text;
+  if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+    new_text = base::i18n::ToLower(new_text);
+
   if (GetRenderText()->insert_mode())
-    model_->InsertText(text);
+    model_->InsertText(new_text);
   else
-    model_->ReplaceText(text);
+    model_->ReplaceText(new_text);
   skip_input_method_cancel_composition_ = false;
   UpdateAfterChange(true, true);
   OnAfterUserAction();
 }
 
 void NativeTextfieldViews::InsertChar(char16 ch, int flags) {
   if (GetTextInputType() == ui::TEXT_INPUT_TYPE_NONE ||
       !ShouldInsertChar(ch, flags)) {
     return;
   }
 
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
   if (GetRenderText()->insert_mode())
     model_->InsertChar(ch);
   else
     model_->ReplaceChar(ch);
   skip_input_method_cancel_composition_ = false;
+
+  if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+    model_->SetText(base::i18n::ToLower(GetText()));
+
   UpdateAfterChange(true, true);
   OnAfterUserAction();
 }
 
 ui::TextInputType NativeTextfieldViews::GetTextInputType() const {
   return textfield_->GetTextInputType();
 }
 
 bool NativeTextfieldViews::CanComposeInline() const {
   return true;
@@ skipping 332 matching lines @@
     if (controller)
       controller->OnAfterCutOrCopy();
     return true;
   }
   return false;
 }
 
 bool NativeTextfieldViews::Paste() {
   const bool success = model_->Paste();
 
-  // Calls TextfieldController::ContentsChanged() explicitly if the paste action
-  // did not change the content at all. See http://crbug.com/79002
-  if (success && GetText() == textfield_->text()) {
-    TextfieldController* controller = textfield_->GetController();
-    if (controller)
-      controller->ContentsChanged(textfield_, textfield_->text());
+  if (success) {
+    // As Paste is handled in model_->Paste(), the RenderText may contain
+    // lower-case characters. This is not consistent with other places

[msw, 2012/04/09 18:29:24]

I think you mean "upper case" here, not "lower-case".
Also remove the dash here for consistency with "lower case" on the line below.

[kochi, 2012/04/10 07:38:11]

Good catch, thanks!

+    // which keeps RenderText only containing lower case characters.
+    if (textfield_->style() & Textfield::STYLE_LOWERCASE)
+      model_->SetText(base::i18n::ToLower(GetText()));
+
+    // Calls TextfieldController::ContentsChanged() explicitly if the paste
+    // action did not change the content at all. See http://crbug.com/79002

[msw, 2012/04/09 18:29:24]

This isn't part of your change, but I don't understand how this makes sense...
|success| is only true if the text changes, so how does this block run in the
case that "the paste action did not change the content at all"? I'll post a note
on the bug.

[kochi, 2012/04/10 07:38:11]

I suppose that this case is for when you have selected
text and paste the exactly same text to that field.
In that case paste succeeds, text is substituted by the
pasted text, but no text change.

Even on that case, textfield controller may want to know
the user interaction.

On 2012/04/09 18:29:24, msw wrote:

[msw, 2012/04/10 07:50:25]

Yes, that's the intent, but TextfieldViewsModel::Paste() has the comment:
// Pastes text from the clipboard at current cursor position. Returns true
// if text has changed after pasting.
Then again, it appears that the comment may just be wrong. (Oops):
http://code.google.com/searchframe#OAMlx_jo-ck/src/ui/views/controls/textfiel...

[xji, 2012/04/10 22:53:27]

Looks like it is the wrong comment.
As long as there is things to be pasted (non-empty clipboard), it returns true.

On 2012/04/10 07:50:25, msw wrote:

[kochi, 2012/04/11 01:56:41]

OK, I changed the original comment in TextfieldViewsModel::Paste().

On 2012/04/10 22:53:27, xji wrote:

+    if (GetText() == textfield_->text()) {
+      TextfieldController* controller = textfield_->GetController();
+      if (controller)
+        controller->ContentsChanged(textfield_, textfield_->text());
+    }
   }
   return success;
 }
 
 void NativeTextfieldViews::TrackMouseClicks(const MouseEvent& event) {
   if (event.IsOnlyLeftMouseButton()) {
     base::TimeDelta time_delta = event.time_stamp() - last_click_time_;
     if (time_delta.InMilliseconds() <= GetDoubleClickInterval() &&
         !ExceededDragThresholdFromLastClickLocation(event)) {
       aggregated_clicks_ = (aggregated_clicks_ + 1) % 3;
@@ skipping 54 matching lines @@
 
 #if defined(USE_AURA)
 // static
 NativeTextfieldWrapper* NativeTextfieldWrapper::CreateWrapper(
     Textfield* field) {
   return new NativeTextfieldViews(field);
 }
 #endif
 
 }  // namespace views