If --force is specified when updating, remove unversioned directories

gclient_scm.py

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 import logging
 import os
 import posixpath
 import re
@@ skipping 424 matching lines @@
     if self._IsRebasing():
       raise gclient_utils.Error('\n____ %s%s\n'
                                 '\nConflict while rebasing this branch.\n'
                                 'Fix the conflict and run gclient again.\n'
                                 'See man git-rebase for details.\n'
                                 % (self.relpath, rev_str))
 
     if verbose:
       print('Checked out revision %s' % self.revinfo(options, (), None))
 
+    # If --force is specified, remove any untracked directories.
+    if options.force:
+      # GIT.CaptureStatus() uses 'dit diff' to compare to a specific SHA1 (the
+      # merge-base by default), so doesn't include untracked files. So we use
+      # 'git ls-files --directory --others --exclude-standard' here directly.
+      paths = scm.GIT.Capture(
+          ['ls-files', '--directory', '--others', '--exclude-standard'],

[M-A Ruel, 2012/02/08 14:43:46]

Note that this will be overzealous if .gitignore is not updated properly. See
the comment at line 958 for an explanation about what's preferable.

http://crbug.com/109763 is about filtering dependencies that are know when doing
a "status", which would be helpful here and below.

[Steve Block, 2012/02/09 17:55:04]

I think that in this case, we want to delete untracked directories which have
just been removed from the repository, even if they are ignored or are a
dependency. This will allow us to use a single change to move a directory to
deps/ and set svn:ignore for that directory.

+          self.checkout_path)
+      if paths:
+        for path in paths.splitlines():
+          if path.endswith('/'):
+            print('\n_____ removing unversioned directory %s' % path)
+            gclient_utils.RemoveDirectory(os.path.join(self.checkout_path,
+                                                       path))
+
+
   def revert(self, options, args, file_list):
     """Reverts local modifications.
 
     All reverted files will be appended to file_list.
     """
     if not os.path.isdir(self.checkout_path):
       # revert won't work if the directory doesn't exist. It needs to
       # checkout instead.
       print('\n_____ %s is missing, synching instead' % self.relpath)
       # Don't reuse the args.
@@ skipping 452 matching lines @@
                    to_info['Repository Root'],
                    self.relpath]
         self._Run(command, options, cwd=self._root_dir)
         from_info['URL'] = from_info['URL'].replace(
             from_info['Repository Root'],
             to_info['Repository Root'])
       else:
         if not options.force and not options.reset:
           # Look for local modifications but ignore unversioned files.
           for status in scm.SVN.CaptureStatus(None, self.checkout_path):
-            if status[0] != '?':
+            if status[0][0] != '?':

[M-A Ruel, 2012/02/08 14:43:46]

Eh, that was bad.

               raise gclient_utils.Error(
                   ('Can\'t switch the checkout to %s; UUID don\'t match and '
                    'there is local changes in %s. Delete the directory and '
                    'try again.') % (url, self.checkout_path))
         # Ok delete it.
         print('\n_____ switching %s to a new checkout' % self.relpath)
         gclient_utils.RemoveDirectory(self.checkout_path)
         # We need to checkout.
         command = ['checkout', url, self.checkout_path]
         command = self._AddAdditionalUpdateFlags(command, options, revision)
         self._RunAndGetFileList(command, options, file_list, self._root_dir)
         return
 
     # If the provided url has a revision number that matches the revision
     # number of the existing directory, then we don't need to bother updating.
     if not options.force and str(from_info['Revision']) == revision:
       if options.verbose or not forced_revision:
         print('\n_____ %s%s' % (self.relpath, rev_str))
       return
 
     command = ['update', self.checkout_path]
     command = self._AddAdditionalUpdateFlags(command, options, revision)
     self._RunAndGetFileList(command, options, file_list, self._root_dir)
 
+    # If --force is specified, remove any untracked files and directories.

[M-A Ruel, 2012/02/08 14:43:46]

You are basically doing a revert only for directories.

What I wanted if to scan file_list that was generated at line 956, look for 'D'
operations and then process these.

Otherwise, it's going to be constantly deleting directories that aren't
svn:ignored properly.

[Steve Block, 2012/02/09 17:55:04]

I considered this approach, but it seems less robust, as if you ever end up with
untracked directories in your working copy (for example, as the result of
'gclient sync' without '--force'), then there's no way to remove them without
manual intervention. So if a later invocation of 'gclient sync' tries to put a
DEPS directory in that location, it will fail, even if you use '--force'.

I guess though that it's sufficient for the bots, which can always use
'--force'. I'll update the patch to try this approach.
Indeed, but they'll immediately be replaced from DEPS. Isn't there an
expectation that svn:ignore is set correctly?

+    if options.force:
+      for status in scm.SVN.CaptureStatus(None, self.checkout_path):
+        if (status[0][0] == '?'
+            and os.path.isdir(os.path.join(self.checkout_path, status[1]))):
+          print('\n_____ removing unversioned directory %s' % status[1])
+          gclient_utils.RemoveDirectory(os.path.join(self.checkout_path,
+                                        status[1]))
+
   def updatesingle(self, options, args, file_list):
     filename = args.pop()
     if scm.SVN.AssertVersion("1.5")[0]:
       if not os.path.exists(os.path.join(self.checkout_path, '.svn')):
         # Create an empty checkout and then update the one file we want.  Future
         # operations will only apply to the one file we checked out.
         command = ["checkout", "--depth", "empty", self.url, self.checkout_path]
         self._Run(command, options, cwd=self._root_dir)
         if os.path.exists(os.path.join(self.checkout_path, filename)):
           os.remove(os.path.join(self.checkout_path, filename))
@@ skipping 141 matching lines @@
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'theirs-conflict'))
     elif options.manually_grab_svn_rev:
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'postpone'))
     elif command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
       new_command.extend(('--accept', 'postpone'))
     return new_command