Issue 9348029: Make inline c blocks non-greedy, and use to add pragma pack to gamepad structure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9348029: Make inline c blocks non-greedy, and use to add pragma pack to gamepad structure (Closed)

Created:
8 years, 10 months ago by scottmg

Modified:
8 years, 10 months ago

Reviewers:
noelallen_use_chromium, brettw

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make inline c blocks non-greedy, and use to add pragma pack to gamepad structure Change the regex to non-greedy so that an idl file can have >1 "#inline c" blocks. Use that to bracket gamepad shared memory structure so that packing matches regardless of compiler settings/bitsize. This part is a temporary fix. The shared memory structure shouldn't be exposed in idl eventually anyway. BUG=113087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121000

Patch Set 1 #

Patch Set 2 : temporarily disable static assert for 2 sided roll #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
M	ppapi/api/dev/ppb_gamepad_dev.idl	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ppapi/c/dev/ppb_gamepad_dev.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	ppapi/generators/idl_lexer.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scottmg

+brettw for OWNERS of webkit/plugins/ppapi/ppapi_plugin_instance.cc The static_assert needs to be disabled until WebKit patch lands ...

8 years, 10 months ago (2012-02-07 21:46:08 UTC) #2

scottmg

On 2012/02/07 21:46:08, scottmg wrote: WebKit side is ready, but this side has to go ...

8 years, 10 months ago (2012-02-08 00:57:09 UTC) #3

lgtm

Expand Messages | Collapse Messages