Cleanup mdn scripts

utils/apidoc/apidoc.dart

Index: utils/apidoc/apidoc.dart
diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart
index ae9e061eba2b0bee5122bd37236f480e67e9dfe7..f344829df1e8a50aef9cb2f7d636fa99e182902d 100644
--- a/utils/apidoc/apidoc.dart
+++ b/utils/apidoc/apidoc.dart
@@ -16,6 +16,8 @@
 
 HtmlDiff _diff;
 
+final GET_PREFIX = 'get:';
+
 void main() {
   var files = new NodeFileSystem();
   parseOptions('../../frog', [] /* args */, files);
@@ -161,7 +163,7 @@ class Apidoc extends doc.Dartdoc {
 
   String _mergeDocs(String mdnComment, String dartComment, String diffComment) {
     // Prefer hand-written Dart comments over stuff from MDN.
-    if (isNonEmpty(dartComment)) {
+    if (0 == 1 && isNonEmpty(dartComment)) {

[Bob Nystrom, 2012/02/01 18:41:13]

Debug code? Remove?

[Jacob, 2012/02/01 21:12:02]

Done.

       // Also include the diff comment if provided.
       if (isNonEmpty(diffComment)) return dartComment + diffComment;
       return dartComment;
@@ -278,11 +280,14 @@ class Apidoc extends doc.Dartdoc {
 
     final mdnType = mdn[member.declaringType.name];
     if (mdnType == null) return null;
-
+    String nameToFind = member.name;

[Bob Nystrom, 2012/02/01 18:41:13]

I think we're moving away from type annotating local variables. It's up to your
preference, but I would encourage you to be consistent with surrounding code
which here isn't annotating them.

[Jacob, 2012/02/01 21:12:02]

Done.

+    if (nameToFind.startsWith(GET_PREFIX)) {
+      nameToFind = nameToFind.substring(GET_PREFIX.length);
+    }
     var mdnMember = null;
-    for (final thisMember in mdnType['members']) {
-      if (thisMember['name'] == member.name) {
-        mdnMember = thisMember;
+    for (Map candidateMember in mdnType['members']) {

[Bob Nystrom, 2012/02/01 18:41:13]

Ditto.

[Jacob, 2012/02/01 21:12:02]

This type cannot possible be inferred and the word Map has the same number of
chars as the word var so I see little advantage in using var instead of Map. 
However switched back to final.

+      if (candidateMember['name'] == nameToFind) {
+        mdnMember = candidateMember;
         break;
       }
     }
@@ -299,8 +304,6 @@ class Apidoc extends doc.Dartdoc {
    * different library than [member].
    */
   String _linkMember(Member member) {
-    final GET_PREFIX = 'get:';
-
     final typeName = member.declaringType.name;
     var memberName = '$typeName.${member.name}';
     if (member.isConstructor || member.isFactory) {