Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: media/audio/linux/alsa_output.cc

Issue 9234066: Detect errors in audio output and report them upstream. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/renderer_webaudiodevice_impl.cc ('k') | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/linux/alsa_output.cc
diff --git a/media/audio/linux/alsa_output.cc b/media/audio/linux/alsa_output.cc
index b3f931d7ae7d2480815e5695dbfeda9149ee7612..75de924bd499e6378fbc32e740ce46ad1508cdca 100644
--- a/media/audio/linux/alsa_output.cc
+++ b/media/audio/linux/alsa_output.cc
@@ -268,6 +268,8 @@ bool AlsaPcmOutputStream::Open() {
// Finish initializing the stream if the device was opened successfully.
if (playback_handle_ == NULL) {
stop_stream_ = true;
+ TransitionTo(kInError);
+ return false;
} else {
bytes_per_output_frame_ = should_downmix_ ? 2 * bytes_per_sample_ :
bytes_per_frame_;
« no previous file with comments | « content/renderer/renderer_webaudiodevice_impl.cc ('k') | media/audio/linux/alsa_output_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698