Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1585083003: EME: Do not special case an empty robustness string. (Closed)

Created:
4 years, 11 months ago by ddorwin
Modified:
4 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Do not special case an empty robustness string. From the EME spec: "The empty string indicates that any ability to decrypt and decode the content type is acceptable." Retain a temporary exception for Chrome OS. BUG=482277, 577777 Committed: https://crrev.com/2de7ec004ece092688f387d4d03301dfccbdb365 Cr-Commit-Position: refs/heads/master@{#369690}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M media/base/key_systems.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
ddorwin
4 years, 11 months ago (2016-01-15 01:03:07 UTC) #3
xhwang
lgtm
4 years, 11 months ago (2016-01-15 01:04:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585083003/20001
4 years, 11 months ago (2016-01-15 01:06:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/166540)
4 years, 11 months ago (2016-01-15 01:13:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585083003/20001
4 years, 11 months ago (2016-01-15 01:29:36 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/166561)
4 years, 11 months ago (2016-01-15 01:37:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1585083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1585083003/20001
4 years, 11 months ago (2016-01-15 05:19:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 05:42:10 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 05:43:10 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de7ec004ece092688f387d4d03301dfccbdb365
Cr-Commit-Position: refs/heads/master@{#369690}

Powered by Google App Engine
This is Rietveld 408576698