Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: content/renderer/media/audio_renderer_mixer_manager_unittest.cc

Issue 10836025: Part 1: Plumb render view ID to render host (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_mixer_manager_unittest.cc
diff --git a/content/renderer/media/audio_renderer_mixer_manager_unittest.cc b/content/renderer/media/audio_renderer_mixer_manager_unittest.cc
index 818bed8b91d04f2483243d7179e7b9ad2cb06daa..ba8d0577e42a48a17fc7a5dd56df1615e066d5c7 100644
--- a/content/renderer/media/audio_renderer_mixer_manager_unittest.cc
+++ b/content/renderer/media/audio_renderer_mixer_manager_unittest.cc
@@ -18,6 +18,7 @@ static const int kBitsPerChannel = 16;
static const int kSampleRate = 48000;
static const int kBufferSize = 8192;
static const ChannelLayout kChannelLayout = CHANNEL_LAYOUT_STEREO;
+static const int kRenderViewId = -2;
// By sub-classing AudioDeviceFactory we've overridden the factory to use our
// CreateAudioDevice() method globally.
@@ -27,7 +28,8 @@ class MockAudioRenderSinkFactory : public AudioDeviceFactory {
virtual ~MockAudioRenderSinkFactory() {}
protected:
- virtual media::MockAudioRendererSink* CreateOutputDevice() OVERRIDE {
+ virtual media::MockAudioRendererSink* CreateOutputDevice(
+ int render_view_id) OVERRIDE {
media::MockAudioRendererSink* sink = new media::MockAudioRendererSink();
EXPECT_CALL(*sink, Start());
EXPECT_CALL(*sink, Stop());
@@ -52,7 +54,7 @@ class AudioRendererMixerManagerTest : public testing::Test {
}
media::AudioRendererMixer* GetMixer(const media::AudioParameters& params) {
- return manager_->GetMixer(params);
+ return manager_->GetMixer(kRenderViewId, params);
}
void RemoveMixer(const media::AudioParameters& params) {
@@ -119,7 +121,8 @@ TEST_F(AudioRendererMixerManagerTest, CreateInput) {
// Create a mixer input and ensure it doesn't instantiate a mixer yet.
EXPECT_EQ(mixer_count(), 0);
- scoped_refptr<media::AudioRendererMixerInput> input(manager_->CreateInput());
+ scoped_refptr<media::AudioRendererMixerInput> input(
+ manager_->CreateInput(kRenderViewId));
EXPECT_EQ(mixer_count(), 0);
// Implicitly test that AudioRendererMixerInput was provided with the expected

Powered by Google App Engine
This is Rietveld 408576698