Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5319)

Unified Diff: chrome/common/localized_error.h

Issue 10830218: Move localized_error from chrome/renderer into chrome/common. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/common/localized_error.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/localized_error.h
diff --git a/chrome/renderer/localized_error.h b/chrome/common/localized_error.h
similarity index 83%
rename from chrome/renderer/localized_error.h
rename to chrome/common/localized_error.h
index ad6d4401cbe3e5dab11fafd210f75bd819345450..2785b4c98a1c771e439a8bf219ff099fc2143ddc 100644
--- a/chrome/renderer/localized_error.h
+++ b/chrome/common/localized_error.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_RENDERER_LOCALIZED_ERROR_H_
-#define CHROME_RENDERER_LOCALIZED_ERROR_H_
+#ifndef CHROME_COMMON_LOCALIZED_ERROR_H_
+#define CHROME_COMMON_LOCALIZED_ERROR_H_
#include <string>
@@ -25,11 +25,15 @@ struct WebURLError;
}
class LocalizedError {
+// Because Chrome for iOS uses LocalizedError but does not include the renderer
+// thread, this class needs to be in a commonly accessible directory.
Nico 2012/08/08 17:56:07 Remove comment
mirandac 2012/08/08 17:59:28 Done.
+
public:
// Fills |error_strings| with values to be used to build an error page used
// on HTTP errors, like 404 or connection reset.
static void GetStrings(const WebKit::WebURLError& error,
- base::DictionaryValue* strings);
+ base::DictionaryValue* strings,
+ const std::string& locale);
// Returns a description of the encountered error.
static string16 GetErrorDetails(const WebKit::WebURLError& error);
@@ -59,4 +63,4 @@ class LocalizedError {
DISALLOW_IMPLICIT_CONSTRUCTORS(LocalizedError);
};
-#endif // CHROME_RENDERER_LOCALIZED_ERROR_H_
+#endif // CHROME_COMMON_LOCALIZED_ERROR_H_
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/common/localized_error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698