Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: build/grit_action.gypi

Issue 10823188: Revert 150118 - Revert 149892 - Remove cygwin disease from grit (python) invocations :) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file is meant to be included into an action to invoke grit in a 5 # This file is meant to be included into an action to invoke grit in a
6 # consistent manner. To use this the following variables need to be 6 # consistent manner. To use this the following variables need to be
7 # defined: 7 # defined:
8 # grit_grd_file: string: grd file path 8 # grit_grd_file: string: grd file path
9 # grit_out_dir: string: the output directory path 9 # grit_out_dir: string: the output directory path
10 10
11 # It would be really nice to do this with a rule instead of actions, but it 11 # It would be really nice to do this with a rule instead of actions, but it
12 # would need to determine inputs and outputs via grit_info on a per-file 12 # would need to determine inputs and outputs via grit_info on a per-file
13 # basis. GYP rules don’t currently support that. They could be extended to 13 # basis. GYP rules don’t currently support that. They could be extended to
14 # do this, but then every generator would need to be updated to handle this. 14 # do this, but then every generator would need to be updated to handle this.
15 15
16 { 16 {
17 'variables': { 17 'variables': {
18 'grit_cmd': ['python', '<(DEPTH)/tools/grit/grit.py'], 18 'grit_cmd': ['python', '<(DEPTH)/tools/grit/grit.py'],
19 }, 19 },
20 'inputs': [ 20 'inputs': [
21 '<!@pymod_do_main(grit_info <@(grit_defines) --inputs <(grit_grd_file))', 21 '<!@pymod_do_main(grit_info <@(grit_defines) --inputs <(grit_grd_file))',
22 ], 22 ],
23 'outputs': [ 23 'outputs': [
24 '<!@pymod_do_main(grit_info <@(grit_defines) --outputs \'<(grit_out_dir)\' < (grit_grd_file))', 24 '<!@pymod_do_main(grit_info <@(grit_defines) --outputs \'<(grit_out_dir)\' < (grit_grd_file))',
25 ], 25 ],
26 'action': ['<@(grit_cmd)', 26 'action': ['<@(grit_cmd)',
27 '-i', '<(grit_grd_file)', 'build', 27 '-i', '<(grit_grd_file)', 'build',
28 '-f', 'GRIT_DIR/../gritsettings/resource_ids', 28 # Combine the -f with the path to avoid gyp reinterpreting the path
29 # in terms of msvs' path structure.
30 '-fGRIT_DIR/../gritsettings/resource_ids',
29 '-o', '<(grit_out_dir)', 31 '-o', '<(grit_out_dir)',
30 '<@(grit_defines)' ], 32 '<@(grit_defines)' ],
33 'msvs_cygwin_shell': 0,
31 'message': 'Generating resources from <(grit_grd_file)', 34 'message': 'Generating resources from <(grit_grd_file)',
32 } 35 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698