Prettify Mac names, rewrite getDisplayPath API call to focus on $HOME

chrome/browser/extensions/api/file_system/file_system_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
 #include "chrome/browser/extensions/platform_app_browsertest_util.h"
 
 using extensions::FileSystemChooseFileFunction;
@@ skipping 40 matching lines @@
 #if defined(OS_WIN) || defined(OS_POSIX)
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiGetDisplayPathPrettify) {
 #if defined(OS_WIN)
   int override = base::DIR_PROFILE;
 #elif defined(OS_POSIX)
   int override = base::DIR_HOME;
 #endif
   ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(override,
       test_root_folder_, false));
 
+  // TODO: this should be the ..._prettify_home test.
   FilePath test_file = test_root_folder_.AppendASCII("gold.txt");
   FileSystemChooseFileFunction::SkipPickerAndAlwaysSelectPathForTest(
       &test_file);
   ASSERT_TRUE(RunPlatformAppTest(
       "api_test/file_system/get_display_path_prettify")) << message_;
 }
 #endif
 
+#if defined(OS_MACOSX)
+IN_PROC_BROWSER_TEST_F(FileSystemApiTest,
+    FileSystemApiGetDisplayPathPrettifyMac) {
+  ASSERT_TRUE(PathService::OverrideAndCreateIfNeeded(base::DIR_DESKTOP,
+      test_root_folder_, false));
+
+  // TODO: The displayName of this folder is going to be "file_system", because it's not a real user-relevant folder to OS X.
+
+  FilePath test_file = test_root_folder_.AppendASCII("gold.txt");
+  FileSystemChooseFileFunction::SkipPickerAndAlwaysSelectPathForTest(
+      &test_file);
+  ASSERT_TRUE(RunPlatformAppTest(
+      "api_test/file_system/get_display_path_prettify_mac")) << message_;
+
+  // TODO: I don't think the test code likes creating filesystems outside the test folders. :(
+#if 0
+  FilePath test_file;
+  ASSERT_TRUE(PathService::Get(base::DIR_DOCUMENTS, &test_file));
+  test_file = test_file.AppendASCII("gold.txt");
+
+  // TODO: this should be the generic test, we just confirm that it's a relative path.
+  FileSystemChooseFileFunction::SkipPickerAndAlwaysSelectPathForTest(
+      &test_file);
+  ASSERT_TRUE(RunPlatformAppTest(
+      "api_test/file_system/get_display_path_prettify_mac")) << "could not run STUFF";
+#endif
+}
+#endif
+
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiOpenExistingFileTest) {
   FilePath test_file = TempFilePath("open_existing.txt", true);
   ASSERT_FALSE(test_file.empty());
   FileSystemChooseFileFunction::SkipPickerAndAlwaysSelectPathForTest(
       &test_file);
   ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/open_existing"))
       << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest,
@@ skipping 116 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemApiTest, FileSystemApiIsWritableTest) {
   FilePath test_file = TempFilePath("writable.txt", true);
   ASSERT_FALSE(test_file.empty());
   FileSystemChooseFileFunction::SkipPickerAndAlwaysSelectPathForTest(
       &test_file);
   ASSERT_TRUE(RunPlatformAppTest(
       "api_test/file_system/is_writable_file_entry")) << message_;
 }