Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1288)

Unified Diff: build/android/run_tests.py

Issue 10781032: restarting adb server before each testing start will cause conflict for multiple emulators (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/run_tests.py
diff --git a/build/android/run_tests.py b/build/android/run_tests.py
index d13f7e90540370736133cda026bb2758a1dba5b5..e204a8122f47de7ff4c7959f104ccf1b52112405 100755
--- a/build/android/run_tests.py
+++ b/build/android/run_tests.py
@@ -337,6 +337,9 @@ def _RunATestSuite(options):
# Wait for all emulators to boot completed.
map(lambda buildbot_emulator: buildbot_emulator.ConfirmLaunch(True),
buildbot_emulators)
+ # Restart adb server as emulator will reset connection when booting,
+ # which will break the connection between adb server and emulator.
bulach 2012/07/17 10:26:08 the comment seems to indicate this is needed per e
John Grabowski 2012/07/17 18:09:22 agree
Wei James(wistoch) 2012/07/20 04:07:01 after applying several patches of bulach, I run th
+ android_commands.RestartAdbServer()
elif options.test_device:
attached_devices = [options.test_device]
else:
« build/android/pylib/android_commands.py ('K') | « build/android/pylib/single_test_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698