Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: pylib/gyp/generator/ninja.py

Issue 10749020: Adds support for the library_dirs key, which appears in the documentation but was never actually im… (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py (revision 1429)
+++ pylib/gyp/generator/ninja.py (working copy)
@@ -738,6 +738,14 @@
[QuoteShellArgument('-I' + self.GypPathToNinja(i), self.flavor)
for i in include_dirs])
+ library_dirs = config.get('library_dirs', [])
+ if self.flavor == 'win':
+ library_dirs = self.msvs_settings.AdjustLibraryDirs(library_dirs,
+ config_name)
+ self.WriteVariableList('libs',
+ [QuoteShellArgument('-L' + self.GypPathToNinja(l), self.flavor)
+ for l in library_dirs])
Nico 2012/07/21 19:14:48 This will might clash with the variable in line 89
Brian Ellis 2012/07/23 23:30:26 I think you mean the 'solink', 'link', etc. rules,
+
pch_commands = precompiled_header.GetPchBuildCommands()
if self.flavor == 'mac':
self.WriteVariableList('cflags_pch_c',

Powered by Google App Engine
This is Rietveld 408576698