Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Side by Side Diff: pylib/gyp/input.py

Issue 10749020: Adds support for the library_dirs key, which appears in the documentation but was never actually im… (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from compiler.ast import Const 5 from compiler.ast import Const
6 from compiler.ast import Dict 6 from compiler.ast import Dict
7 from compiler.ast import Discard 7 from compiler.ast import Discard
8 from compiler.ast import List 8 from compiler.ast import List
9 from compiler.ast import Module 9 from compiler.ast import Module
10 from compiler.ast import Node 10 from compiler.ast import Node
(...skipping 17 matching lines...) Expand all
28 28
29 # base_path_sections is a list of sections defined by GYP that contain 29 # base_path_sections is a list of sections defined by GYP that contain
30 # pathnames. The generators can provide more keys, the two lists are merged 30 # pathnames. The generators can provide more keys, the two lists are merged
31 # into path_sections, but you should call IsPathSection instead of using either 31 # into path_sections, but you should call IsPathSection instead of using either
32 # list directly. 32 # list directly.
33 base_path_sections = [ 33 base_path_sections = [
34 'destination', 34 'destination',
35 'files', 35 'files',
36 'include_dirs', 36 'include_dirs',
37 'inputs', 37 'inputs',
38 'library_dirs',
Mark Mentovai 2012/07/17 19:58:34 It shouldn’t be neecssary to add anything ending w
Brian Ellis 2012/07/17 20:26:52 Okay. I was surprised by the inclusion of include
38 'libraries', 39 'libraries',
39 'outputs', 40 'outputs',
40 'sources', 41 'sources',
41 ] 42 ]
42 path_sections = [] 43 path_sections = []
43 44
44 45
45 def IsPathSection(section): 46 def IsPathSection(section):
46 # If section ends in one of these characters, it's applied to a section 47 # If section ends in one of these characters, it's applied to a section
47 # without the trailing characters. '/' is notably absent from this list, 48 # without the trailing characters. '/' is notably absent from this list,
(...skipping 2428 matching lines...) Expand 10 before | Expand all | Expand 10 after
2476 ValidateRunAsInTarget(target, target_dict, build_file) 2477 ValidateRunAsInTarget(target, target_dict, build_file)
2477 ValidateActionsInTarget(target, target_dict, build_file) 2478 ValidateActionsInTarget(target, target_dict, build_file)
2478 2479
2479 # Generators might not expect ints. Turn them into strs. 2480 # Generators might not expect ints. Turn them into strs.
2480 TurnIntIntoStrInDict(data) 2481 TurnIntIntoStrInDict(data)
2481 2482
2482 # TODO(mark): Return |data| for now because the generator needs a list of 2483 # TODO(mark): Return |data| for now because the generator needs a list of
2483 # build files that came in. In the future, maybe it should just accept 2484 # build files that came in. In the future, maybe it should just accept
2484 # a list, and not the whole data dict. 2485 # a list, and not the whole data dict.
2485 return [flat_list, targets, data] 2486 return [flat_list, targets, data]
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698