content/public/common/find_match_rect_android.h - Issue 10536066: android content shell bringup.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/common/find_match_rect_android.h

Issue 10536066: android content shell bringup. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add comments Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/public/common/file_chooser_params.h ('K') | « content/public/common/file_chooser_params.h ('k') | content/shell/android/java/org/chromium/content_shell/ShellView.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
	jam 2012/06/08 23:45:09 are you planning on exposing this later? i only se are you planning on exposing this later? i only see it used inside content for now. Yaron 2012/06/09 01:02:11 From downstream it looks like the native side is o Show quoted text On 2012/06/08 23:45:09, John Abd-El-Malek wrote: > are you planning on exposing this later? i only see it used inside content for > now. From downstream it looks like the native side is only used in content. John Grabowski 2012/06/12 01:46:30 Don't think so. Show quoted text On 2012/06/08 23:45:09, John Abd-El-Malek wrote: > are you planning on exposing this later? i only see it used inside content for > now. Don't think so. jam 2012/06/12 17:44:02 if it's not used outside of content, move this to Show quoted text On 2012/06/12 01:46:30, John Grabowski wrote: > On 2012/06/08 23:45:09, John Abd-El-Malek wrote: > > are you planning on exposing this later? i only see it used inside content for > > now. > > Don't think so. if it's not used outside of content, move this to content/common
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_COMMON_FIND_MATCH_RECT_ANDROID_H_

	6 #define CONTENT_PUBLIC_COMMON_FIND_MATCH_RECT_ANDROID_H_

	7 #pragma once

	8

	9 struct FindMatchRect {
	jam 2012/06/08 23:45:09 nit: everything in content API has to be in conten nit: everything in content API has to be in content namespace
	10 public:

	11 FindMatchRect();

	12 FindMatchRect(float left, float top, float right, float bottom);
	jam 2012/06/08 23:45:09 where is the cc file for this? if you can do this where is the cc file for this? if you can do this inline, that's preferred. if you must add a .cc file to avoid clang errors, then it would be in this directory. Yaron 2012/06/09 01:02:11 Downstream it's in the same dir. I guess you can a Show quoted text On 2012/06/08 23:45:09, John Abd-El-Malek wrote: > where is the cc file for this? if you can do this inline, that's preferred. if > you must add a .cc file to avoid clang errors, then it would be in this > directory. Downstream it's in the same dir. I guess you can add it in this patch, John.
	13 float left;

	14 float top;

	15 float right;

	16 float bottom;

	17 };

	18

	19 #endif // CONTENT_PUBLIC_COMMON_FIND_MATCH_RECT_ANDROID_H_

OLD	NEW