Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Issue 10533085: Add a unit test for run_test_cases.py. (Closed)

Created:
8 years, 6 months ago by M-A Ruel
Modified:
8 years, 6 months ago
Reviewers:
cmp
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add a unit test for run_test_cases.py. Make Progress to output to stderr, it automatically flushes and it doesn't interfere with the output, making testing easier and stdout more usable in general, like if piping the results. NOTRY=true R=cmp@chromium.org BUG= TEST=new integration test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141686

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -5 lines) Patch
A tools/isolate/data/gtest_fake/__init__.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/isolate/data/gtest_fake/gtest_fake.py View 1 1 chunk +84 lines, -0 lines 0 comments Download
M tools/isolate/run_test_cases.py View 4 chunks +11 lines, -4 lines 0 comments Download
A tools/isolate/run_test_cases_test.py View 1 1 chunk +61 lines, -0 lines 0 comments Download
M tools/isolate/worker_pool.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
8 years, 6 months ago (2012-06-11 21:05:05 UTC) #1
cmp
https://chromiumcodereview.appspot.com/10533085/diff/1/tools/isolate/data/gtest_fake/gtest_fake.py File tools/isolate/data/gtest_fake/gtest_fake.py (right): https://chromiumcodereview.appspot.com/10533085/diff/1/tools/isolate/data/gtest_fake/gtest_fake.py#newcode49 tools/isolate/data/gtest_fake/gtest_fake.py:49: nit: insert an empty line https://chromiumcodereview.appspot.com/10533085/diff/1/tools/isolate/run_test_cases_test.py File tools/isolate/run_test_cases_test.py (right): ...
8 years, 6 months ago (2012-06-12 16:32:10 UTC) #2
M-A Ruel
https://chromiumcodereview.appspot.com/10533085/diff/1/tools/isolate/data/gtest_fake/gtest_fake.py File tools/isolate/data/gtest_fake/gtest_fake.py (right): https://chromiumcodereview.appspot.com/10533085/diff/1/tools/isolate/data/gtest_fake/gtest_fake.py#newcode49 tools/isolate/data/gtest_fake/gtest_fake.py:49: On 2012/06/12 16:32:10, cmp wrote: > nit: insert an ...
8 years, 6 months ago (2012-06-12 17:33:48 UTC) #3
cmp
lgtm
8 years, 6 months ago (2012-06-12 17:39:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10533085/5001
8 years, 6 months ago (2012-06-12 17:40:53 UTC) #5
commit-bot: I haz the power
Try job failure for 10533085-5001 (retry) on mac_rel for step "update". It's a second try, ...
8 years, 6 months ago (2012-06-12 17:46:47 UTC) #6
M-A Ruel
On 2012/06/12 17:46:47, I haz the power (commit-bot) wrote: > Try job failure for 10533085-5001 ...
8 years, 6 months ago (2012-06-12 18:05:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10533085/5001
8 years, 6 months ago (2012-06-12 18:05:55 UTC) #8
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 18:07:09 UTC) #9
Change committed as 141686

Powered by Google App Engine
This is Rietveld 408576698