base/android/jni_string.h - Issue 10532081: replace string16 with StringPiece16 in ConvertUTF16ToJavaString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_string.h

Issue 10532081: replace string16 with StringPiece16 in ConvertUTF16ToJavaString() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove redundant header files" Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/android/jni_string.h

diff --git a/base/android/jni_string.h b/base/android/jni_string.h

index 1987f048b916c4a8d031480369664f0f014a835e..1e9074263fc02c52df5ad8cccde930ba524306b8 100644

--- a/base/android/jni_string.h

+++ b/base/android/jni_string.h

@@ -29,7 +29,7 @@ string16 ConvertJavaStringToUTF16(const JavaRef<jstring>& str);

// Convert a string16 to a Java string.

ScopedJavaLocalRef<jstring> ConvertUTF16ToJavaString(

- JNIEnv* env, const string16& str);

+ JNIEnv* env, const base::StringPiece16& str);

joth 2012/06/11 23:39:38 nit: one param per line (see "OK3" in http://www.c

Wei James(wistoch) 2012/06/12 01:25:29 fixed. thanks

} // namespace android

} // namespace base

« no previous file with comments | « no previous file | base/android/jni_string.cc » ('j') | base/android/jni_string.cc » ('J')