replace string16 with StringPiece16 in ConvertUTF16ToJavaString()

base/android/jni_string.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/android/jni_string.h"
 
 #include "base/android/jni_android.h"
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 
 namespace {
 
 // Internal version that does not use a scoped local pointer.
-jstring ConvertUTF16ToJavaStringImpl(JNIEnv* env, const string16& str) {
+jstring ConvertUTF16ToJavaStringImpl(JNIEnv* env,
+                                     const base::StringPiece16& str) {
   jstring result = env->NewString(str.data(), str.length());
   base::android::CheckException(env);
   return result;
 }
 
 }
 
 namespace base {
 namespace android {
 
@@ skipping 28 matching lines @@
   string16 result(chars, env->GetStringLength(str));
   env->ReleaseStringChars(str, chars);
   CheckException(env);
   return result;
 }
 
 string16 ConvertJavaStringToUTF16(const JavaRef<jstring>& str) {
   return ConvertJavaStringToUTF16(AttachCurrentThread(), str.obj());
 }
 
-// TODO(joth): change this to accept const StringPiece16&.
 ScopedJavaLocalRef<jstring> ConvertUTF16ToJavaString(JNIEnv* env,
-                                                     const string16& str) {
+                                           const base::StringPiece16& str) {

[joth, 2012/06/11 23:39:38]

likewise as this fit when aligned with the open parenthesis, all params should
be moved to the OK3 indent-by-4 spaces format.
(and line 37 isn't quite right either for that style... one param per line....)

[Wei James(wistoch), 2012/06/12 01:25:29]

fixed. thanks

   return ScopedJavaLocalRef<jstring>(env,
                                      ConvertUTF16ToJavaStringImpl(env, str));
 }
 
 }  // namespace android
 }  // namespace base