Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: src/allocation.h

Issue 10448007: Split an allocation policy into an allocator and a deallocator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Make TemplateHashMapImpl consistent with the rest of the approach. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/allocation-inl.h » ('j') | src/list.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 95
96 // The normal strdup functions use malloc. These versions of StrDup 96 // The normal strdup functions use malloc. These versions of StrDup
97 // and StrNDup uses new and calls the FatalProcessOutOfMemory handler 97 // and StrNDup uses new and calls the FatalProcessOutOfMemory handler
98 // if allocation fails. 98 // if allocation fails.
99 char* StrDup(const char* str); 99 char* StrDup(const char* str);
100 char* StrNDup(const char* str, int n); 100 char* StrNDup(const char* str, int n);
101 101
102 102
103 // Allocation policy for allocating in the C free store using malloc 103 // Allocation policy for allocating in the C free store using malloc
104 // and free. Used as the default policy for lists. 104 // and free. Used as the default policy for lists.
105 class FreeStoreAllocationPolicy { 105 class FreeStoreAllocator {
106 public: 106 public:
107 INLINE(static void* New(size_t size)) { return Malloced::New(size); } 107 INLINE(void* New(size_t size)) { return Malloced::New(size); }
108 INLINE(static void Delete(void* p)) { Malloced::Delete(p); }
109 }; 108 };
110 109
111 110
111 class FreeStoreDeallocator {
112 public:
113 INLINE(void Delete(void *ptr)) { Malloced::Delete(ptr); }
114 };
115
116
117 struct FreeStoreAllocationPolicy {
118 typedef FreeStoreAllocator Alloc;
119 typedef FreeStoreDeallocator Dealloc;
120 };
121
122
112 // Allocation policy for allocating in preallocated space. 123 // Allocation policy for allocating in preallocated space.
113 // Used as an allocation policy for ScopeInfo when generating 124 // Used as an allocation policy for ScopeInfo when generating
114 // stack traces. 125 // stack traces.
115 class PreallocatedStorage { 126 class PreallocatedStorage {
116 public: 127 public:
117 explicit PreallocatedStorage(size_t size); 128 explicit PreallocatedStorage(size_t size);
118 size_t size() { return size_; } 129 size_t size() { return size_; }
119 130
120 // TODO(isolates): Get rid of these-- we'll have to change the allocator
121 // interface to include a pointer to an isolate to do this
122 // efficiently.
123 static inline void* New(size_t size);
124 static inline void Delete(void* p);
125
126 private: 131 private:
127 size_t size_; 132 size_t size_;
128 PreallocatedStorage* previous_; 133 PreallocatedStorage* previous_;
129 PreallocatedStorage* next_; 134 PreallocatedStorage* next_;
130 135
131 void LinkTo(PreallocatedStorage* other); 136 void LinkTo(PreallocatedStorage* other);
132 void Unlink(); 137 void Unlink();
133 138
134 friend class Isolate; 139 friend class Isolate;
135 140
136 DISALLOW_IMPLICIT_CONSTRUCTORS(PreallocatedStorage); 141 DISALLOW_IMPLICIT_CONSTRUCTORS(PreallocatedStorage);
137 }; 142 };
138 143
139 144
145 class PreallocatedStorageAllocator {
146 public:
147 INLINE(void* New(size_t size));
148 };
149
150
151 class PreallocatedStorageDeallocator {
152 public:
153 INLINE(void Delete(void* ptr));
154 };
155
156
157 struct PreallocatedStorageAllocationPolicy {
158 typedef PreallocatedStorageAllocator Alloc;
159 typedef PreallocatedStorageDeallocator Dealloc;
160 };
161
162
140 } } // namespace v8::internal 163 } } // namespace v8::internal
141 164
142 #endif // V8_ALLOCATION_H_ 165 #endif // V8_ALLOCATION_H_
OLDNEW
« no previous file with comments | « no previous file | src/allocation-inl.h » ('j') | src/list.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698