Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: test/cctest/test-list.cc

Issue 10448007: Split an allocation policy into an allocator and a deallocator. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed the issues pointed out. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/splay-tree-inl.h ('K') | « src/zone-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 15 matching lines...) Expand all
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #include <stdlib.h> 28 #include <stdlib.h>
29 #include <string.h> 29 #include <string.h>
30 #include "v8.h" 30 #include "v8.h"
31 #include "cctest.h" 31 #include "cctest.h"
32 32
33 using namespace v8::internal; 33 using namespace v8::internal;
34 34
35 // Use a testing allocator that clears memory before deletion. 35 // Use a testing allocator that clears memory before deletion.
36 class ZeroingAllocationPolicy { 36 class ZeroingAllocator {
37 public: 37 public:
38 static void* New(size_t size) { 38 void* New(size_t size) {
39 // Stash the size in the first word to use for Delete. 39 // Stash the size in the first word to use for Delete.
40 size_t true_size = size + sizeof(size_t); 40 size_t true_size = size + sizeof(size_t);
41 size_t* result = reinterpret_cast<size_t*>(malloc(true_size)); 41 size_t* result = reinterpret_cast<size_t*>(malloc(true_size));
42 if (result == NULL) return result; 42 if (result == NULL) return result;
43 *result = true_size; 43 *result = true_size;
44 return result + 1; 44 return result + 1;
45 } 45 }
46 };
46 47
47 static void Delete(void* ptr) { 48
49 class ZeroingDeallocator {
50 public:
51 void Delete(void* ptr) {
48 size_t* true_ptr = reinterpret_cast<size_t*>(ptr) - 1; 52 size_t* true_ptr = reinterpret_cast<size_t*>(ptr) - 1;
49 memset(true_ptr, 0, *true_ptr); 53 memset(true_ptr, 0, *true_ptr);
50 free(true_ptr); 54 free(true_ptr);
51 } 55 }
52 }; 56 };
53 57
58
59 struct ZeroingAllocationPolicy {
60 typedef ZeroingAllocator Allocator;
61 typedef ZeroingDeallocator Deallocator;
62 };
63
54 // Check that we can add (a reference to) an element of the list 64 // Check that we can add (a reference to) an element of the list
55 // itself. 65 // itself.
56 TEST(ListAdd) { 66 TEST(ListAdd) {
57 // Add elements to the list to grow it to its capacity. 67 // Add elements to the list to grow it to its capacity.
58 List<int, ZeroingAllocationPolicy> list(4); 68 List<int, ZeroingAllocationPolicy> list(4);
59 list.Add(1); 69 list.Add(1);
60 list.Add(2); 70 list.Add(2);
61 list.Add(3); 71 list.Add(3);
62 list.Add(4); 72 list.Add(4);
63 73
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 164
155 TEST(DeleteEmpty) { 165 TEST(DeleteEmpty) {
156 { 166 {
157 List<int>* list = new List<int>(0); 167 List<int>* list = new List<int>(0);
158 delete list; 168 delete list;
159 } 169 }
160 { 170 {
161 List<int> list(0); 171 List<int> list(0);
162 } 172 }
163 } 173 }
OLDNEW
« src/splay-tree-inl.h ('K') | « src/zone-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698