Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10332192: char16 array should be null-terminated to be assigned to string16 (Closed)

Created:
8 years, 7 months ago by Wei James(wistoch)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

char16 array should be null-terminated to be assigned to string16 BUG=128319 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/android/address_detector.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Wei James(wistoch)
this issue will make AddressDetectorTest failed on x86 android platform. It is strange it will ...
8 years, 7 months ago (2012-05-16 10:17:09 UTC) #1
Leandro Graciá Gil
LGTM. Thanks for finding and fixing this! On 2012/05/16 10:17:09, James Wei wrote: > this ...
8 years, 7 months ago (2012-05-16 10:36:34 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 7 months ago (2012-05-16 12:51:06 UTC) #3
Leandro Graciá Gil
Sorry, I forgot that my committer status is "provisional" since 2 years ago and we ...
8 years, 7 months ago (2012-05-16 14:04:00 UTC) #4
piman
lgtm
8 years, 7 months ago (2012-05-16 17:22:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/james.wei@intel.com/10332192/1
8 years, 7 months ago (2012-05-16 21:59:53 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 00:19:29 UTC) #7
Change committed as 137576

Powered by Google App Engine
This is Rietveld 408576698