Issue 10273034: Assume that the compiler comes from the SDK if it is detected but Visual Studio is not installed. U…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10273034: Assume that the compiler comes from the SDK if it is detected but Visual Studio is not installed. U… (Closed)

Created:
8 years, 7 months ago by alexeypa (please no reviews)

Modified:
8 years, 7 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://git.chromium.org/external/gyp.git@master

Visibility:
Public.

More Reviews

Description

Assume that the compiler comes from the SDK if it is detected but Visual Studio is not installed. Use the seput script from the SDK in such a case.

Patch Set 2 : CR feedback #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -25 lines)			Patch
	M	pylib/gyp/MSVSVersion.py	View	1	6 chunks	+32 lines, -9 lines	0 comments	Download
	M	pylib/gyp/msvs_emulation.py	View		2 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

This is the fix for SDK-only setup detection. I was able to build chrome.exe using ...

8 years, 7 months ago (2012-05-01 20:52:27 UTC) #1

scottmg

Works for me locally, and lgtm. http://chromiumcodereview.appspot.com/10273034/diff/1/pylib/gyp/MSVSVersion.py File pylib/gyp/MSVSVersion.py (right): http://chromiumcodereview.appspot.com/10273034/diff/1/pylib/gyp/MSVSVersion.py#newcode275 pylib/gyp/MSVSVersion.py:275: os.path.join(path, '..'), True)) ...

8 years, 7 months ago (2012-05-02 19:24:16 UTC) #2

alexeypa (please no reviews)

FYI http://chromiumcodereview.appspot.com/10273034/diff/1/pylib/gyp/MSVSVersion.py File pylib/gyp/MSVSVersion.py (right): http://chromiumcodereview.appspot.com/10273034/diff/1/pylib/gyp/MSVSVersion.py#newcode275 pylib/gyp/MSVSVersion.py:275: os.path.join(path, '..'), True)) On 2012/05/02 19:24:17, scottmg wrote: ...

8 years, 7 months ago (2012-05-02 19:29:47 UTC) #3

Committed as r1352.

Expand Messages | Collapse Messages

Issue 10273034: Assume that the compiler comes from the SDK if it is detected but Visual Studio is not installed. U… (Closed)

Description

Patch Set 1 #

Patch Set 2 : CR feedback #

Messages