Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10264015: Don't override _HAS_TR1 on VS > 2008 (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

When building with VS 2010, causes warnings like: c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\yvals.h(21) : warning C4005: '_HAS_TR1' : macro redefinition command-line arguments : see previous definition of '_HAS_TR1' (This is the same change that was made in Chromium's common.gypi) BUG=125606 r8503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
8 years, 7 months ago (2012-05-01 16:30:11 UTC) #1
krasin
Nick, could you please take a look? Thanks, Ivan Krasin
8 years, 7 months ago (2012-05-01 21:49:24 UTC) #2
noelallen_use_chromium
LGTM
8 years, 7 months ago (2012-05-01 22:53:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/scottmg@chromium.org/10264015/1
8 years, 7 months ago (2012-05-01 22:54:26 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 7 months ago (2012-05-01 23:18:40 UTC) #5
M-A Ruel
The CQ for NaCl is broken until someone fixes it.
8 years, 7 months ago (2012-05-01 23:52:29 UTC) #6
scottmg
I tried to dcommit, but got "Authorization failed: Authorization failed at c:\src\depot_tools\git_bin/libexec/git-core/git-svn line 4441". (svn ...
8 years, 7 months ago (2012-05-02 19:36:55 UTC) #7
Nico
8 years, 7 months ago (2012-05-04 18:25:01 UTC) #8
Landed in r8503

Powered by Google App Engine
This is Rietveld 408576698