Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: build/common.gypi

Issue 10051021: apk-based test runner work for android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a098a1c451fa9b7c8fa88da3c04ed0b62751a22a..893e3f717af5b9f8619a57f11ea90857f3d6355c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -788,10 +788,11 @@
# http://crbug.com/115320
'notifications%': 0,
- # Builds the gtest targets as a shared_library.
- # TODO(michaelbai): Use the fixed value 'shared_library' once it
- # is fully supported.
'gtest_target_type%': '<(gtest_target_type)',
+ # TODO(jrg): when 'gtest_target_type'=='shared_libary' and
+ # OS==android, make all gtest_targets depend on
+ # testing/android/native_test.gyp:native_test_apk.
+ ### 'gtest_target_type': 'shared_libary',
# Uses system APIs for decoding audio and video.
'use_libffmpeg%': '0',
@@ -2356,6 +2357,11 @@
'ldflags': [
'-Wl,-shared,-Bsymbolic',
],
+ # Use of -nostdlib prevents the compiler from bringing
+ # in crtbegin_dynamic.o et al, so we get an undefined
+ # reference to ___dso_handle when building
+ # gtest_target_type==shared_library.
+ 'ldflags!': [ '-nostdlib' ],
}],
],
}],

Powered by Google App Engine
This is Rietveld 408576698